Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixes versions and changelogs #5455

Merged
merged 4 commits into from
Jun 9, 2024

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Jun 8, 2024

Description

Notes & open questions

I noticed some mistakes in the versions and in changelogs, introduced by #5347 and some other PRs.

I carefully checked all changelogs and added - unreleased tag on their latest unreleased version to help avoiding such issues in the future. That tag should be removed before releasing and added if a new unreleased version is introduced.

I suggest you to check release-plz.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@oblique oblique force-pushed the chore/fix-versions-changelogs branch from e708267 to 97af7f3 Compare June 8, 2024 12:09
@dariusc93
Copy link
Member

I thought it was discussed to leave the unreleased suffix omitted from the changelog or was it decided to reintroduce it?

@oblique
Copy link
Contributor Author

oblique commented Jun 8, 2024

I was not aware. @jxs Do you know?

@dariusc93
Copy link
Member

dariusc93 commented Jun 8, 2024

Though I do remember in a PR I was told to drop the suffix, but this is the reference I can find about it #4541 (comment).

EDIT:
comment that mentioned about leaving it out

@oblique
Copy link
Contributor Author

oblique commented Jun 8, 2024

Thanks. I removed the unreleased tag.

Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yianis! Yeah Darius is right we deprecated the usage of unreleased

transports/websocket/CHANGELOG.md Outdated Show resolved Hide resolved
transports/websocket/Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@jxs jxs added the send-it label Jun 9, 2024
@mergify mergify bot merged commit 927428f into libp2p:master Jun 9, 2024
72 checks passed
@oblique oblique deleted the chore/fix-versions-changelogs branch June 9, 2024 05:51
TimTinkers pushed a commit to unattended-backpack/rust-libp2p that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants